Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonRpcSigner does not handle decimal string values #2948

Closed
ricmoo opened this issue Apr 29, 2022 Discussed in #2947 · 2 comments
Closed

JsonRpcSigner does not handle decimal string values #2948

ricmoo opened this issue Apr 29, 2022 Discussed in #2947 · 2 comments
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Apr 29, 2022

Discussed in #2947

Originally posted by piyushnh April 28, 2022

Describe your Issue

Error: invalid hexlify value (argument="value", value="80000000000000000", code=INVALID_ARGUMENT, version=bytes/5.6.1)
    at Logger.makeError (index.js?dd68:219:1)
    at Logger.throwError (index.js?dd68:228:1)
    at Logger.throwArgumentError (index.js?dd68:231:1)
    at hexlify (index.js?69bb:191:1)
    at hexValue (index.js?69bb:231:1)
    at eval (json-rpc-provider.js?8679:600:35)
    at Array.forEach (<anonymous>)
    at Function.hexlifyTransaction (json-rpc-provider.js?8679:596:1)
    at eval (json-rpc-provider.js?8679:213:1)

I'm getting this error when using the provider from Magic auth to place a transaction (https://magic.link/docs/advanced/blockchains/ethereum/javascript)

@ricmoo ricmoo added bug Verified to be an issue. on-deck This Enhancement or Bug is currently being worked on. labels Apr 29, 2022
@ricmoo
Copy link
Member Author

ricmoo commented Apr 29, 2022

Reproduction steps:

(async function() {
    const provider = new ethers.providers.JsonRpcProvider("http:/\/localhost:8545");
    const signer = provider.getSigner();
    await signer.sendTransaction({
        to: signer.getAddress(),
        value: "800"
    });
})();

@ricmoo
Copy link
Member Author

ricmoo commented May 3, 2022

This should be fixed in 5.6.5.

Let me know if there are any more problems.

Thanks! :)

@ricmoo ricmoo closed this as completed May 3, 2022
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified to be an issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

1 participant