Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clique-base network block miner tests from CI #1967

Closed
ricmoo opened this issue Aug 27, 2021 · 0 comments
Closed

Remove Clique-base network block miner tests from CI #1967

ricmoo opened this issue Aug 27, 2021 · 0 comments
Labels
discussion Questions, feedback and general information. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@ricmoo
Copy link
Member

ricmoo commented Aug 27, 2021

This is a quick issue to help track behaviour I've seen that is holding up the CI.

Historically nodes for the Clique-based networks (i.e. Rinkeby and Görli) have returned the zero address for the miner.

Recently some (but not all) backends are returning the block producer, instead. So for now I am removing the miner from the testing for these networks.
ricmoo added a commit that referenced this issue Aug 27, 2021
@ricmoo
Temporarily remove the block miner for clique-based networks from CI …
8320d53 
…testing (#1967).
@ricmoo ricmoo added discussion Questions, feedback and general information. on-deck This Enhancement or Bug is currently being worked on. fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Aug 27, 2021
@ricmoo ricmoo closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Questions, feedback and general information. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ricmoo