This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Upgrade CI provider to use GH Actions in place of Travis #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanio
force-pushed
the
useGHActions
branch
3 times, most recently
from
5c1cf1b to
916eb0c
Compare
holgerd77
approved these changes
May 9, 2020
This was referenced May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Running the test suite in the browser takes ~23 mins due to some of the heavier crypto ops so it can be left off as a required check for quicker PRs, but it is nice to have confirmation that everything works properly in Chrome and Firefox. I sped up the browser test suite a bit by slicing off some
test permutations when
isRunningInKarma(), and can probably find some more optimizations by further skipping slower or redundant tests, but I will leave that for a future PR.