Public Blockchain.getTotalDifficulty() method #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| const td = await (<any>blockchain)._getTd(genesis.hash(), new BN(0)) | ||
| st.ok(td.eq(genesis.header.difficulty), 'should perform _getTd correctly') | ||
| // cast the blockchain as <any> in order to get access to the private getTotalDifficulty | ||
| const td = await (<any>blockchain).getTotalDifficulty(genesis.hash(), new BN(0)) |
There was a problem hiding this comment.
Don't have to cast here as any anymore, but won't let this be a blocker
jochem-brouwer
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be included in the
rc.1release.Addresses comment from @jochem-brouwer from here #923 (comment) to make
Blockchain._getTd()public. Function is renamed togetTotalDifficulty()for better clarity, CHANGELOG entry has been added and the blockchain docs rebuild.