Update HF to Istanbul #906
Conversation
holgerd77
requested review from
ryanio,
evertonfraga,
cgewecke and
jochem-brouwer
…and documentation
holgerd77
force-pushed
the
update-hardfork-to-istanbul
branch
from
955a30f to
227fdfe
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -34,7 +34,7 @@ export class BlockHeader { | |||
| public mixHash!: Buffer | |||
| public nonce!: Buffer | |||
|
|
|||
| readonly _common: Common | |||
| public readonly _common: Common | |||
There was a problem hiding this comment.
Making default public visibility explicit 👍
| @@ -14,7 +14,7 @@ export class Block { | |||
| public readonly uncleHeaders: BlockHeader[] = [] | |||
| public readonly txTrie = new Trie() | |||
|
|
|||
| private readonly _common: Common | |||
| public readonly _common: Common | |||
There was a problem hiding this comment.
A question for context: is the idea to change _common visibility so it can be available on the tests?
There was a problem hiding this comment.
yeah in general I agree with this so we don't have to keep doing (block as any)._common anymore 😄
There was a problem hiding this comment.
Yeah, that is for the tests. Always not sure if this is the best way to tackle, but then do out of lack on alternative ideas on practical paths here.
There was a problem hiding this comment.
The changes are solid.
Another question for context: @holgerd77 why Istanbul, and not Muir Glacier?
| block._common.hardfork(), | ||
| 'istanbul', | ||
| 'should initialize with the current default HF', | ||
| ) |
|
@evertonfraga |
|
@holgerd77 got it! As i suspected. |
This PR updates the default HF to Istanbul in preparation for the v5 release.