Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement debug_verbosity #3809

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Dec 2, 2024

This change provides an implementation for debug_verbosity to allow for setting the verbosity level of the client logger as a part of the work being done in #3781 in order to integrate, develop, and provide an ethereumjs repl console. This work also relates to #1114 and increasing JSON-RPC API coverage.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (d814248) to head (9c4fee9).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.23% <ø> (ø)
client 73.64% <100.00%> (+0.02%) ⬆️
common 89.89% <ø> (ø)
devp2p 71.95% <ø> (+0.10%) ⬆️
evm 64.93% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.09% <ø> (+0.25%) ⬆️
rlp 95.11% <ø> (ø)
statemanager 67.81% <ø> (ø)
tx 76.56% <ø> (ø)
util 72.81% <ø> (ø)
vm 57.30% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 100d77d into master Dec 3, 2024
41 checks passed
@scorbajio scorbajio deleted the debug-verbosity-rpc-implementation branch December 3, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants