Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all the lint stuff #3802

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix all the lint stuff #3802

merged 1 commit into from
Nov 20, 2024

Conversation

acolytec3
Copy link
Contributor

This addresses all the current linter complaints

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.50282% with 100 lines in your changes missing coverage. Please review.

Project coverage is 75.82%. Comparing base (e86eace) to head (bbaebb5).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 74.00% <ø> (ø)
common 89.89% <ø> (ø)
devp2p 71.95% <ø> (ø)
evm 64.93% <33.91%> (+<0.01%) ⬆️
genesis 100.00% <ø> (ø)
mpt 51.83% <ø> (+0.14%) ⬆️
rlp 95.11% <100.00%> (ø)
statemanager 68.84% <ø> (ø)
tx 76.52% <ø> (ø)
util 72.81% <ø> (ø)
vm 57.30% <0.00%> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

holgerd77
holgerd77 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@holgerd77 holgerd77 merged commit f364de7 into master Nov 20, 2024
40 of 41 checks passed
@holgerd77 holgerd77 deleted the make-the-linter-happy branch November 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: client package: evm package: rlp package: vm package: wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @holgerd77