Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t8n: do not create empty coinbase account from SpuriousDragon on state.reward == 0 #3720

Merged
merged 5 commits into from
Oct 4, 2024
Merged

t8n: do not create empty coinbase account from SpuriousDragon on state.reward == 0 #3720

merged 5 commits into from
Oct 4, 2024

Conversation

jochem-brouwer
Copy link
Member

Fixes a bug in t8ntool filler where we create empty coinbase accounts

@jochem-brouwer jochem-brouwer marked this pull request as ready for review October 3, 2024 18:48
@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.11%. Comparing base (4470cc3) to head (d3414fb).
Report is 85 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 67.57% <ø> (-5.89%) ⬇️
blockchain 83.49% <ø> (?)
client ?
common 89.85% <ø> (?)
devp2p 0.00% <ø> (?)
genesis 0.00% <ø> (?)
trie 52.19% <ø> (?)
tx ?
util 70.93% <ø> (?)
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

ScottyPoi
ScottyPoi approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottyPoi ScottyPoi merged commit 3136bd2 into master Oct 4, 2024
39 checks passed
@scorbajio scorbajio deleted the fix-t8ntool branch October 4, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottyPoi ScottyPoi ScottyPoi approved these changes

Assignees
No one assigned
Labels
package: vm PR state: needs review type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochem-brouwer @ScottyPoi @holgerd77