Common/Monorepo: Remove NetworkId #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,12 +61,12 @@ describe('[Common]: Custom chains', () => { | |||
|
|
|||
| it('custom() -> behavior', () => { | |||
| let common = createCustomCommon({ chainId: 123 }) | |||
| assert.deepEqual(common.networkId(), BigInt(1), 'should default to mainnet base chain') | |||
| assert.equal(common.consensusAlgorithm(), 'casper', 'should default to mainnet base chain') | |||
There was a problem hiding this comment.
Is this right? Why are we not checking chainID?
There was a problem hiding this comment.
Yes, that's correct, the goal of this test is to not check for the value passed (chainId), but to check that the other values remain the mainnet-specific ones.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
|
Have addressed, ready for re-review! |
ScottyPoi
reviewed
Jul 18, 2024
Co-authored-by: Scotty <66335769+ScottyPoi@users.noreply.github.com>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
networkIdfrom Common and upstream usages and configuration files. Client is keeping for now as a CLI option (but deprecated) for a smoother transition on things like Docker and stuff.Ready for review! 🙂