Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests directory for nyc coverage report #342

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Exclude tests directory for nyc coverage report #342

merged 1 commit into from
Aug 13, 2018

Conversation

holgerd77
Copy link
Member

Switching from istanbul to nyc somehow resulted in the tests folder being included in the coverage report, which reduced coverage below the threshold value, see #334.

This PR should fix this by explicitly excluding the tests directory.

holgerd77
holgerd77 commented Aug 13, 2018
View reviewed changes
Copy link
Member Author

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No production code touched, obviously fixed by coverage now working correctly, will merge.

@holgerd77 holgerd77 merged commit dfe2eb0 into master Aug 13, 2018
@axic axic deleted the fix-nyc-coverage-exclude branch September 18, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holgerd77 @evertonfraga