-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Devnet0 fixtures: BLS Fixes (Common/EVM), Empty System Address (VM) #3400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Failing fixtures: (just as in 3388)
|
…s/ethereumjs-monorepo into eip2935-test-runner-transition
All fixtures pass 🎉 Only need to fix the outdated BLS tests on EVM by updating them to: https://eips.ethereum.org/assets/eip-2537/test-vectors Note: these test vectors also have "failing" cases which we are currently not covering (note: these test vectors likely are the same as we run on the fixtures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: one test has been moved into the new eip-2537-BLS.spec.ts. The other tests are covered by the test cases in the new test runner.
npm run test:blockchain -- --fork=CancunToPragueAtTime15k --dir=../Devnet0/blockchain_tests/
npm run test:blockchain -- --fork=Prague --dir=../Devnet0/blockchain_tests/
Note: this PR is a placeholder for any bugfixes which might arise if we find those via the tests. It should pass:
npm run test:blockchain -- --fork=Prague --dir=../Devnet0/
Bugs found and solved: