common: add spec test for 2935 contract code and update history storage address #3373
Conversation
g11tech
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| await vm.stateManager.putContractCode(historyAddress, contract2935Code) | ||
|
|
||
| const result = await vm.runTx({ tx, block, skipHardForkValidation: true }) | ||
| const blockHashi = result.execResult.returnValue |
There was a problem hiding this comment.
Small nit: above 15 lines can be easily DRYied by setting up a small method taking in i and getting back the blockhash or something similar and then reused in the test below. This will likely also ease the writing of additional test cases.
There was a problem hiding this comment.
(can also quickly do if you answer in the next 20 min)
There was a problem hiding this comment.
ahh seeing this now, will do and update
this will not change until after devnet0, lets take this in and then re-PR when changes come in spec |
test the 2935 contract code as per the eip
and update history save address, however old address is till overriden for kaustine6 (tested and verified)
its likely that the code and hence address will be modified at which point the address and the code for testing will be updated