evm: ignore precompile addresses for some target access events #3366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
added
PR state: merge ready
package: evm
and removed
PR state: merge ready
labels
acolytec3
reviewed
Apr 24, 2024
| if ( | ||
| common.isActivatedEIP(6800) && | ||
| runState.interpreter._evm.getPrecompile(toAddress) === undefined | ||
| ) { | ||
| // TODO: add check if toAddress is not a precompile |
There was a problem hiding this comment.
Can we remove this comment here?
acolytec3
previously approved these changes
Apr 24, 2024
g11tech
force-pushed
the
ignore-precompile-accesses
branch
from
1d301df to
484d39a
Compare
acolytec3
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
LGTM! @holgerd77 could we admin merge this? The only test failure is browser tests which are failing for some unknown vitest related reason at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address a pending change of ignoring precompiles for some target access events