-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM build to client #3359
Add ESM build to client #3359
Conversation
…-the-very-first-time
…-the-very-first-time
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
packages/client/bin/startRpc.ts
Outdated
@@ -176,7 +176,7 @@ export function startRPCServers(client: EthereumClient, args: RPCArgs) { | |||
rpcDebug, | |||
rpcDebugVerbose, | |||
logger, | |||
}) | |||
}) //@ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary? Can we just typecast instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was an earlier left over. Looks like we don't need it at all. Will remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions/comments. Looks great
This replaces the current client build process with one that is ESM only.
Notable changes
"type":"module"
topackage.json
npm run build
require(...
usage inclient
fs-extra
dependency since not needed (and was causing issues with the ESM build)bin/cli.ts
for theservers
bitTODOs: