Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monorepo: remove EIP 2315 (JUMPSUB) #3342

Merged
merged 3 commits into from
Apr 3, 2024
Merged

monorepo: remove EIP 2315 (JUMPSUB) #3342

merged 3 commits into from
Apr 3, 2024

Conversation

jochem-brouwer
Copy link
Member

This PR removes EIP 2315. The opcodes have been reclaimed by TSTOREs/TLOADs

TODO: check if we can now optimize runState.validJumps[dest] === 1 (do we have any other cases of a valid JUMP or not?)

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 36.66667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 82.92%. Comparing base (107660e) to head (0e065f4).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 82.12% <ø> (-3.62%) ⬇️
blockchain 90.92% <ø> (-0.70%) ⬇️
client 84.92% <ø> (+0.31%) ⬆️
common 94.02% <ø> (-4.42%) ⬇️
devp2p 81.36% <ø> (-0.76%) ⬇️
ethash ?
evm 73.30% <36.66%> (-0.41%) ⬇️
genesis 99.98% <ø> (ø)
statemanager 74.71% <ø> (-1.45%) ⬇️
trie 59.60% <ø> (-29.41%) ⬇️
tx 85.70% <ø> (-9.38%) ⬇️
util 81.32% <ø> (-1.85%) ⬇️
vm 61.56% <ø> (-17.82%) ⬇️
wallet 87.25% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer marked this pull request as ready for review April 3, 2024 06:16
acolytec3
acolytec3 previously approved these changes Apr 3, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3
Copy link
Contributor

Gonna go ahead and merge here. I think we could try optimizing _getValidJumpDests in a separate PR dedicated to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants