Replace native events
with eventemitter3
#3330
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an exploration of replacing
eventEmitter
witheventemitter3
to improve browser compatibility since the native nodejs Event Emitter seems to have some typing issues/interface variance from the browser equivalent.Known impacts - requires removing get/
setMaxListeners
andprependListener/Once
There is some type difference in the generics where our current use of
<E extends keyod T>
inasyncEventEmitter
that causes Typescript to complainThe
once
function on the async event emitter does not appear to work properly now. It appears that the step in the process where it removes the listener after executiong the calback never occurs.