Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix Releases (Missing Trie debug dependency) #3271

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Feb 8, 2024

Hotfix releases following #3261 with new releases for the already published versions adding a missing debug dependency to the @ethereumjs/trie package.

Additionally some README and CHANGELOG additions I forgot to commit before pushing, not necessary for the releases itself to be merged, can be taken in afterwards (or at any time).

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b258fd9) 86.85% compared to head (d05a8a8) 86.87%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.33% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.69% <ø> (ø)
common 98.25% <ø> (ø)
devp2p 82.12% <ø> (ø)
ethash ∅ <ø> (∅)
evm 74.33% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ?
statemanager 75.86% <ø> (ø)
trie 89.55% <ø> (+0.38%) ⬆️
tx 95.45% <ø> (ø)
util 89.13% <ø> (ø)
vm 80.20% <ø> (ø)
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer previously approved these changes Feb 8, 2024
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jochem-brouwer
Copy link
Member

Ah wait, browser tests are failing, have retriggered that CI

@holgerd77
Copy link
Member Author

Please do not merge here yet!

@holgerd77 holgerd77 dismissed jochem-brouwer’s stale review February 8, 2024 16:32

Will add some more stuff, see chat

@holgerd77 holgerd77 changed the title Some Release README additions Hotfix Releases (Missing Trie debug dependency) Feb 8, 2024
@holgerd77
Copy link
Member Author

Ok, ready for (re-)review, now including the hotfix releases (see chat)!

Would appreciate a quick review/approval, then I can continue with the releases! 🙏

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit ff43fc1 into master Feb 8, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants