-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix Releases (Missing Trie debug dependency) #3271
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah wait, browser tests are failing, have retriggered that CI |
Please do not merge here yet! |
Will add some more stuff, see chat
…HANGELOG entry, updated upstream dependency versions
… (@ethereumjs/tx v5.2.1)
… (@ethereumjs/devp2p v6.1.1)
… (@ethereumjs/statemanager v2.2.1)
… (@ethereumjs/block v5.1.1)
Ok, ready for (re-)review, now including the hotfix releases (see chat)! Would appreciate a quick review/approval, then I can continue with the releases! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hotfix releases following #3261 with new releases for the already published versions adding a missing
debug
dependency to the@ethereumjs/trie
package.Additionally some README and CHANGELOG additions I forgot to commit before pushing, not necessary for the releases itself to be merged, can be taken in afterwards (or at any time).