Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates #3212

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Dependency Updates #3212

merged 6 commits into from
Jan 4, 2024

Conversation

scorbajio
Copy link
Contributor

@scorbajio scorbajio commented Dec 28, 2023

This change updates the following dependencies from the following packages:

client:

  • fs-extra 10.1.0 to 11.2.0
  • @types/fs-extra 9.0.13 to 11.0.4

trie:

(major version update is breaking due to circular dependency breaking browser tests for trie)

  • @types/readable-stream 2.3.15 to 4.0.10
  • readable-stream 3.6.2 to 4.5.2

devp2p:

(being handled in #3188)

  • lru-cache 7.18.3 to 10.1.0

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbe755c) 88.28% compared to head (a8d2485) 87.88%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 87.52% <ø> (ø)
blockchain 91.60% <ø> (ø)
client 84.66% <ø> (+<0.01%) ⬆️
common 98.25% <ø> (ø)
devp2p 82.11% <ø> (?)
ethash ∅ <ø> (∅)
evm 76.60% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ∅ <ø> (?)
statemanager 86.29% <ø> (ø)
trie 89.76% <ø> (ø)
tx 95.73% <ø> (ø)
util 89.13% <ø> (ø)
vm 80.83% <ø> (ø)
wallet 91.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Maybe take the lru-cache update out here for now, lru is always hairy, since this is such a central dependency, also behavior changed substantially (especially around the usage of null, undefined as cache values) so a simple update should be handled with care and often also requires changes on types and code logic.

I think also @acolytec3 did some parallel update on this in some parallel PR, so that's another remark, but that should also be aligned and coordinated.

So, but for here: guess buest to leave lru-cache out and keep this to some other few dependencies.

@scorbajio scorbajio force-pushed the dependency-updates branch 2 times, most recently from d572f54 to 448f4a4 Compare January 2, 2024 23:37
@scorbajio scorbajio requested a review from holgerd77 January 2, 2024 23:44
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acolytec3
acolytec3 previously approved these changes Jan 3, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acolytec3
acolytec3 previously approved these changes Jan 3, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acolytec3
acolytec3 previously approved these changes Jan 4, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye obsolete deps (and may our installs be faster now that we're nearly 100 deps lighter)

@scorbajio scorbajio merged commit 9046347 into master Jan 4, 2024
46 checks passed
@scorbajio scorbajio deleted the dependency-updates branch January 4, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants