Client: Async VM Initialization #3187
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@scorbajio @acolytec3 thanks a lot for the continued test fixes, that helps a lot, both practically and on my motivation to continue here (since it always a bit daunting to "cause" so many new test failures with the need to fix "just" for a somewhat simple cleanup)! 🤩 |
| @@ -259,8 +265,8 @@ describe('[Miner]', async () => { | |||
| // no skipHardForkValidation | |||
| const miner = new Miner({ config: goerliConfig, service }) | |||
| const { txPool } = service | |||
| await service.execution.setupMerkleVM() | |||
There was a problem hiding this comment.
There are several (most except for 1) cases where this also works with await service.execution.open(), just tested, will replace since we should rather use the "public" (internal) API for things like that for setup which then closer resembles the real situation.
|
Tested mainnet sync on this up to a point with a proven block execution (so: a contract execution). This worked fine! |
This moves to a proper async VM initialization in the client. Lot's of tests to fix and adopt, but already fixed a lot, so getting there.
Open to be continued during the day if someone feels like it, otherwise I'll continue tomorrow.