Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix canonical reset of the chain by the skeleton #3078

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Oct 2, 2023

on devnet9, because of some reasons skeleton was resetting the chain and these are the remedial fixes that have been deployed on the nodes there

BUILD on top of

TODO

  • monitor and see if this fixes the issues there

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #3078 (8be5b4f) into master (09601d2) will decrease coverage by 4.41%.
The diff coverage is 79.16%.

❗ Current head 8be5b4f differs from pull request most recent head 08d659c. Consider uploading reports for the commit 08d659c to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client 87.58% <79.16%> (-0.09%) ⬇️
common 98.19% <ø> (ø)
ethash ?
evm 71.87% <ø> (?)
rlp ?
statemanager 90.23% <ø> (?)
trie 90.39% <ø> (ø)
tx ?
util 86.97% <ø> (?)
vm 76.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

cleanup and better logging for newpayload execution skip

fix caching scenario

fix the beacon syncronizer and skeleton opening
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@acolytec3 acolytec3 merged commit 05b48dc into master Oct 3, 2023
@holgerd77 holgerd77 deleted the fix-chainreset branch October 4, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants