Add Holesky testnet #2982
Merged
Add Holesky testnet #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
jochem-brouwer
force-pushed
the
holesky
branch
from
b803e99 to
e5ff245
Compare
acolytec3
previously approved these changes
Aug 23, 2023
packages/common/src/chains.ts
Outdated
| }, | ||
| { | ||
| // The forkHash will remain same as mergeForkIdTransition is post merge, | ||
| // terminal block: https://sepolia.etherscan.io/block/1450408 |
There was a problem hiding this comment.
Is this comment (or at least this link) still applicable?
There was a problem hiding this comment.
No this is not applicable in this case, thanks 😄
g11tech
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/eth-clients/holesky
I have asked for confirmation of fork hashes on R&D (they should be right).
Also tested client startup (which works) with the
--network holeskyflag.