Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename datagas to blobgas - eip 4844 pr 7354 #2919

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Rename datagas to blobgas - eip 4844 pr 7354 #2919

merged 10 commits into from
Jul 28, 2023

Conversation

acolytec3
Copy link
Contributor

@acolytec3 acolytec3 commented Jul 28, 2023 •
edited by g11tech
Loading

This implements EIP 4844 PR 7354 to rename dataGas to blobGas in all instances

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #2919 (22a670f) into master (6308469) will decrease coverage by 1.39%.
The diff coverage is 90.27%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <92.50%> (ø)
blockchain 92.58% <0.00%> (ø)
client ?
common 98.64% <100.00%> (ø)
ethash ∅ <ø> (∅)
evm 69.95% <ø> (ø)
rlp ?
statemanager 85.16% <ø> (ø)
trie 90.17% <ø> (?)
tx 95.96% <100.00%> (ø)
util 86.77% <ø> (ø)
vm 79.20% <86.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 requested a review from g11tech July 28, 2023 14:14
@g11tech g11tech marked this pull request as ready for review July 28, 2023 14:50
g11tech
g11tech previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a commit which PR seems to be on some lag to show, but should work post it

approving the changes tentatively

@g11tech g11tech force-pushed the eip7354---blobgas branch from ca25c59 to a15df5d Compare July 28, 2023 14:51
@g11tech g11tech changed the title Rename datagas to blobgas - eip 7354 Rename datagas to blobgas - eip 4844 pr 7354 Jul 28, 2023
g11tech
g11tech previously approved these changes Jul 28, 2023
View reviewed changes
g11tech
g11tech approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@acolytec3 acolytec3 merged commit 174772e into master Jul 28, 2023
@acolytec3 acolytec3 deleted the eip7354---blobgas branch July 28, 2023 16:54
@holgerd77
Copy link
Member

holgerd77 commented Jul 31, 2023 •
edited
Loading

Just to highlight the new type: spec updates label we have for some time now in the context of this PR, I think this is helpful for PR classification, since lately (and especially with 4844) PRs with some changes regarding spec updates have gotten pretty common/frequent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
package: block package: blockchain package: client package: common package: evm package: tx package: vm PR state: merge ready type: spec updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acolytec3 @holgerd77 @g11tech