Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add Cancun CFI EIPs for devnet8 and fix eip-4788 block building issues #2892

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jul 14, 2023

get ethereumjs ready for devnet8

spec link for EIPs to be included:

image

@g11tech g11tech added PR state: merge ready package: common target: master Work to be done towards master branch labels Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #2892 (fa65be3) into master (0af7309) will increase coverage by 0.05%.
The diff coverage is 95.29%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <100.00%> (+0.04%) ⬆️
blockchain 92.58% <ø> (ø)
client 87.18% <ø> (-0.02%) ⬇️
common 97.13% <ø> (ø)
ethash ?
evm 69.95% <ø> (+0.33%) ⬆️
rlp ?
statemanager 85.16% <ø> (ø)
trie 90.04% <ø> (ø)
tx 95.96% <ø> (ø)
util 87.14% <ø> (ø)
vm 78.15% <94.80%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Ah nice, that's also more complete for the releases to get these in. 👍

VM API tests still failing though.

@g11tech g11tech changed the title common: add Cancun CFI EIPs for devnet8 common: add Cancun CFI EIPs for devnet8 and fix eip-4788 block building issues Jul 15, 2023
@holgerd77
Copy link
Member

Updated this via UI

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 54e10a2 into master Jul 17, 2023
@holgerd77 holgerd77 deleted the devnet8 branch July 17, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants