Monorepo: make _* methods protected / _common -> common #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
changed the title
holgerd77
force-pushed
the
make-non-public-members-protected
branch
from
852c5ce to
de7a5e4
Compare
|
Rebased this via UI |
| @@ -97,7 +97,7 @@ describe('Istanbul: EIP-152', () => { | |||
| const res = precompile09({ | |||
| data: hexToBytes('0x' + testCase.input), | |||
| gasLimit: BigInt(20), | |||
| _common: common, | |||
| common: common, | |||
There was a problem hiding this comment.
Suggested change
| common: common, | |
| common, |
Super nit but we can now do this
There was a problem hiding this comment.
Will ignore this for now, we should really activate linter for test files though, this would then be caught and fixed.
| @@ -108,7 +108,7 @@ describe('Istanbul: EIP-152', () => { | |||
| const res = precompile09({ | |||
| data: hexToBytes('0x' + testCase.input), | |||
| gasLimit: BigInt(10000000), | |||
| _common: common, | |||
| common: common, | |||
There was a problem hiding this comment.
Suggested change
| common: common, | |
| common, |
jochem-brouwer
approved these changes
Jul 4, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2852
This is a first test on the above issue to get a feeling on the extent of the task, will start with theCommonlibrary.This also refactors the
EventEmitterstructure fromCommonaligning this with EVM and client by separating theEventEmitterfrom the main class and make this an own property to allow for a cleaner API (code completion).Update: this is now taking on all the libraries. This is on purpose a "rough" update, primarily targeting the main classes where the API is most visible. Everything else would just take too much time and effort at this point.