Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: fix the dataGasPrice calculation in running the tx #2779

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 13, 2023

fix the bug in vm runTx where the dataGasPrice calc was still being based on the block's parent from ssz times.

this was caught in devnet-6 runs where for the first time where consecutive blocks with blobs were produced

@g11tech g11tech added PR state: merge ready package: vm target: master Work to be done towards master branch labels Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2779 (9a8ffec) into master (a86fe25) will increase coverage by 2.25%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client ?
common 97.00% <ø> (ø)
devp2p ?
ethash ?
evm ?
rlp ∅ <ø> (∅)
statemanager ?
trie 89.92% <ø> (ø)
tx ?
util ?
vm 82.89% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Yay for testnets catching bugs.

@acolytec3 acolytec3 merged commit bc9a613 into master Jun 13, 2023
@acolytec3 acolytec3 deleted the fix-runtx-gasprice branch June 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vm PR state: merge ready target: master Work to be done towards master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants