vm: Discard blob txs with missing blobs for block building #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
added
package: vm
package: client
target: master
g11tech
force-pushed
the
remove-non-networkblobtx
branch
from
dda32d4 to
1bda1bf
Compare
g11tech
commented
Jun 10, 2023
| @@ -325,18 +325,6 @@ export class Miner { | |||
| `Miner: Assembled block full (gasLeft: ${gasLimit - blockBuilder.gasUsed})` | |||
| ) | |||
| } | |||
| } else if ((error as Error).message.includes('tx has a different hardfork than the vm')) { | |||
There was a problem hiding this comment.
this is a case no longer required as we stopped throwing on tx have different hardfork than vm, but instead set it to vm's if vm's and block's hf match
gabrocheleau
approved these changes
Jun 10, 2023
|
Looks good to me, can be merged once tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes sure that a block is not build with missing blobs (i.e. from non network wrapper tx)
TODO:
- [ ] ensure same in gossipTO be dealt in a different PR after discussion