Monorepo: Vitest Test Transition / ESM Part 2 #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
esm-part-2-5-with-tests
branch
3 times, most recently
from
29b4b4c to
ccb8fd3
Compare
acolytec3
reviewed
Jun 12, 2023
packages/common/package.json
Outdated
| "docs:build": "typedoc --options typedoc.js", | ||
| "lint": "../../config/cli/lint.sh", | ||
| "lint:diff": "../../config/cli/lint-diff.sh", | ||
| "lint:fix": "../../config/cli/lint-fix.sh", | ||
| "prepublishOnly": "../../config/cli/prepublish.sh", | ||
| "tape": "tape -r ts-node/register", | ||
| "test": "npm run test:node && npm run test:browser", | ||
| "test:browser": "karma start karma.conf.js", | ||
| "test:node": "npm run tape -- ./test/*.spec.ts", | ||
| "test:browser": "npx vitest run --browser=chrome", |
There was a problem hiding this comment.
Suggested change
| "test:browser": "npx vitest run --browser=chrome", | |
| "test:browser": "npx vitest run --browser.name=chrome --browser.headless |
holgerd77
force-pushed
the
esm-part-2-5-with-tests
branch
from
dfb4171 to
32c4d42
Compare
holgerd77
commented
Jun 14, 2023
| @@ -14,10 +14,9 @@ import { BlockHeader } from '../src/header.js' | |||
| import { fakeExponential, getNumBlobs } from '../src/helpers.js' | |||
| import { Block } from '../src/index.js' | |||
|
|
|||
| import * as gethGenesis from './testdata/4844-hardfork.json' | |||
| import gethGenesis from './testdata/4844-hardfork.json' | |||
There was a problem hiding this comment.
TBH: on these cases I always totally have no idea what version to take and what difference this makes. 🤔
There was a problem hiding this comment.
For this one, if I understand how Typescript works with ESM, a namespace import like this converts the JSON into an object with a default export so it imported it as { "default": [ blocksData ] } instead of [ blocksData ].
holgerd77
force-pushed
the
esm-part-2-5-with-tests
branch
from
bd4c9c4 to
bd3f1b2
Compare
holgerd77
force-pushed
the
esm-part-2-5-with-tests
branch
from
65b71ef to
d20eaa2
Compare
|
Rebased this and added various lint fixes |
* VM: fix linting * VM: add .js path references * Ethash: tape -> vitest transition * Ethash: ad .js file path references
acolytec3
previously approved these changes
Jun 16, 2023
acolytec3
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition of Tape tests to Vitest, also ESM .js file reference integration.
First results look promising 🙂.