Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: Update the kzg validation and replace trusted setup with latest #2756

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 6, 2023

  • Updated the kzg validation
  • updating https://github.com/ethereum/c-kzg-4844/blob/main/src/trusted_setup.txt as the devnet6 setup as c-kzg team indicated that the trusted setup encoding has been updated (and new trusted setup is also different from the devnet4)
  • Also adds a cli option to specify trusted setup for client run (option has been requested by EF devops for testing ease)

This updated setup + validation works with a corresponding devnet-6 lodestar build (image yet to be updated) ✔️

TODO:

  • Fix test cases which are hardcoded with devnet4 setup

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2756 (c90b049) into master (3b1976b) will increase coverage by 0.00%.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 91.08% <ø> (ø)
blockchain 90.72% <ø> (ø)
client 87.21% <ø> (+0.01%) ⬆️
common 97.00% <ø> (ø)
devp2p 89.50% <ø> (+0.09%) ⬆️
ethash ∅ <ø> (∅)
evm 79.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 86.28% <ø> (ø)
trie 89.92% <ø> (ø)
tx 95.69% <83.33%> (-0.12%) ⬇️
util 81.13% <ø> (ø)
vm 83.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech changed the title tx: Update the kzg valiation and replace trusted setup with latest tx: Update the kzg validation and replace trusted setup with latest Jun 7, 2023
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@acolytec3 acolytec3 merged commit 5c513d1 into master Jun 7, 2023
@holgerd77 holgerd77 deleted the trustedsetup branch June 20, 2023 09:48
@holgerd77
Copy link
Member

Oh, nice, only now learning about this new --trustedSetup option, cool! 😎 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants