Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Remove ssz from monorepo #2717

Merged
merged 1 commit into from
May 22, 2023
Merged

util: Remove ssz from monorepo #2717

merged 1 commit into from
May 22, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented May 22, 2023 •
edited
Loading

Since the 4844 transactions are now RLP, currently there is no need for ssz in the monorepo and can be later re-introduced when required.

@g11tech g11tech added PR state: merge ready package: block package: tx package: util type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. labels May 22, 2023
@g11tech g11tech marked this pull request as draft May 22, 2023 10:16
@codecov
Copy link

codecov bot commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #2717 (61d571a) into master (02f0b0b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.82% <ø> (+0.06%) ⬆️
blockchain 90.72% <ø> (ø)
client 86.97% <ø> (ø)
common 97.05% <ø> (ø)
devp2p 89.40% <ø> (+0.16%) ⬆️
ethash ∅ <ø> (∅)
evm 79.31% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 80.92% <ø> (ø)
trie 89.94% <ø> (ø)
tx 95.76% <100.00%> (-0.01%) ⬇️
util 81.13% <ø> (-0.21%) ⬇️
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech marked this pull request as ready for review May 22, 2023 10:37
@g11tech g11tech changed the base branch from new-payloadv3-vhashes to master May 22, 2023 10:37
@g11tech g11tech added the target: master Work to be done towards master branch label May 22, 2023
@holgerd77
Copy link
Member

Rebased this via UI

holgerd77
holgerd77 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval after rebase, LGTM

holgerd77
holgerd77 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approval after rebase, LGTM

@holgerd77 holgerd77 merged commit d3db69b into master May 22, 2023
@holgerd77 holgerd77 deleted the remove-ssz branch May 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

@paulmillr paulmillr paulmillr approved these changes

Assignees
No one assigned
Labels
package: block package: tx package: util PR state: merge ready target: master Work to be done towards master branch type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g11tech @holgerd77 @paulmillr