Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common/Block/EVM: Deprecation Cleanup Work #2706

Merged
merged 6 commits into from
May 17, 2023
Merged

Common/Block/EVM: Deprecation Cleanup Work #2706

merged 6 commits into from
May 17, 2023

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented May 17, 2023 •
edited
Loading

Deprecation cleanup work for the upcoming breaking releases.

Will track the changes in the following list:

  • Common: remove deprecated nextHardforkBlock(), isNextHardforkBlock() and isHardforkBlock() methods
  • Blockchain: remove deprecated getHead() method
  • EVM: rename SHA3 opcode -> KECCAK256
  • EVM: rename DIFFICULTY opcode to PREVRANDAO post Merge

@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #2706 (9ad718b) into master (a820095) will decrease coverage by 1.72%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.30% <ø> (ø)
blockchain 90.72% <100.00%> (+0.21%) ⬆️
client 86.98% <ø> (?)
common 97.05% <ø> (+0.98%) ⬆️
devp2p 89.47% <ø> (?)
ethash ∅ <ø> (∅)
evm 79.38% <100.00%> (?)
rlp ∅ <ø> (∅)
statemanager 80.92% <ø> (ø)
trie 90.06% <ø> (+0.12%) ⬆️
tx 95.50% <ø> (ø)
util 81.34% <ø> (ø)
vm 81.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 force-pushed the deprecation-cleanup-work branch 2 times, most recently from f426030 to 835c866 Compare May 17, 2023 09:00
@holgerd77 holgerd77 mentioned this pull request May 17, 2023
Closed
@holgerd77 holgerd77 force-pushed the deprecation-cleanup-work branch from 835c866 to 11fb1fb Compare May 17, 2023 09:24
@holgerd77 holgerd77 force-pushed the deprecation-cleanup-work branch from 11fb1fb to df49a23 Compare May 17, 2023 09:37
@holgerd77 holgerd77 mentioned this pull request May 17, 2023
Closed
@holgerd77 holgerd77 requested a review from g11tech May 17, 2023 09:40
jochem-brouwer
jochem-brouwer previously approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I am also super happy with df49a23, great that this works, and love the test!!

g11tech
g11tech previously approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@holgerd77
Copy link
Member Author

@jochem-brouwer @g11tech thanks for the reviews, some tests still failing though, will have a look.

@jochem-brouwer
Copy link
Member

Ah, I know - it is because we dont have PREVRANDAO gas costs :)

@holgerd77 holgerd77 dismissed stale reviews from g11tech and jochem-brouwer via 9ad718b May 17, 2023 11:58
jochem-brouwer
jochem-brouwer approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM!

@jochem-brouwer jochem-brouwer merged commit 5b393bf into master May 17, 2023
@holgerd77 holgerd77 deleted the deprecation-cleanup-work branch May 17, 2023 12:54
@holgerd77 holgerd77 changed the title Monorepo: Deprecation Cleanup Work Common/Block/EVM: Deprecation Cleanup Work Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@g11tech g11tech g11tech left review comments

Assignees
No one assigned
Labels
breaking package: block package: common package: evm PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerd77 @jochem-brouwer @g11tech