Client Memory Optimizations #2675
Conversation
…dicated generic stateManager.spec.ts file, add copy() tests
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -56,15 +56,21 @@ export abstract class Execution { | |||
| */ | |||
| async open(): Promise<void> { | |||
| this.started = true | |||
| this.config.logger.info('Setup EVM execution.') | |||
| if (this.config.execution) { | |||
There was a problem hiding this comment.
i think we should not change the log UX here as the execution could still be triggered by beacon sync for e.g. and then stop would not log the stop message.
instead we should just add a log when we trigger execution run in full service start
There was a problem hiding this comment.
👍
Could you eventually directly push ah update?
| @@ -162,7 +162,7 @@ export class FullEthereumService extends EthereumService { | |||
| } | |||
| await super.start() | |||
| this.miner?.start() | |||
| if (!this.config.execCommon.gteHardfork(Hardfork.Paris)) { | |||
| if (!this.config.execCommon.gteHardfork(Hardfork.Paris) && this.config.execution) { | |||
| void this.execution.run(true, true) | |||
There was a problem hiding this comment.
| void this.execution.run(true, true) | |
| this.logger.info("Triggering execution of already downloaded blocks if any") | |
| void this.execution.run(true, true) |
something like this...
|
Will admin merge here for procedural reasons, we can see if codecov not reporting was eventually a one time thing on the next PR. |
Memory optimizations for the client and in general, can either be directly merged or used as a base for additional pushes, don't really care, what fits better.