Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Make Shanghai the default hardfork #2655

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Apr 20, 2023

Shift the default hf to Shanghai

(build on top of #2652 ), would be rebased once 2652 merges

@g11tech g11tech added PR state: WIP package: common type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. target: develop-v7 labels Apr 20, 2023
@g11tech g11tech changed the base branch from g11tech/merge-to-paris to develop-v7 April 20, 2023 09:42
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop-v7@2005528). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.57% <0.00%> (?)
blockchain 90.43% <0.00%> (?)
client 87.04% <0.00%> (?)
common 95.76% <0.00%> (?)
devp2p 91.61% <0.00%> (?)
ethash ∅ <0.00%> (?)
evm 79.35% <0.00%> (?)
rlp ∅ <0.00%> (?)
statemanager 88.08% <0.00%> (?)
trie 90.52% <0.00%> (?)
tx 95.45% <0.00%> (?)
util 81.50% <0.00%> (?)
vm 84.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech force-pushed the g11tech/default-shanghai branch from 9c35b7c to 072d751 Compare April 20, 2023 12:53
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot, cool! 🙂 👍

Will directly merge in.

@holgerd77 holgerd77 merged commit 8f5cce2 into develop-v7 Apr 21, 2023
@holgerd77 holgerd77 deleted the g11tech/default-shanghai branch April 21, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardfork: shanghai package: common PR state: merge ready type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants