Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @chainsafe/ssz to 0.11.0 #2622

Merged
merged 5 commits into from
Apr 8, 2023
Merged

Bump @chainsafe/ssz to 0.11.0 #2622

merged 5 commits into from
Apr 8, 2023

Conversation

FrederikBolding
Copy link
Contributor

@FrederikBolding FrederikBolding commented Apr 6, 2023 •
edited
Loading

Bumps @chainsafe/ssz to 0.11.0.

The current version of @chainsafe/ssz uses an AssemblyScript based SHA-256 implementation that causes issues on some platforms since it requires WebAssembly for execution (e.g. in sites or extensions with strict CSPs).

This new version uses a pure JS implementation (@noble/hashes) as the default hasher for SHA-256 and should fix some of these aforementioned incompatibility issues.

For more context see: ChainSafe/ssz#313

@codecov
Copy link

codecov bot commented Apr 6, 2023 •
edited
Loading

Codecov Report

Merging #2622 (a579b4e) into master (c83f11b) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.41% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.06% <ø> (ø)
common 95.74% <ø> (ø)
devp2p 91.84% <ø> (+0.16%) ⬆️
ethash ∅ <ø> (∅)
evm 79.39% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.61% <ø> (ø)
trie 90.02% <ø> (ø)
tx 94.38% <ø> (ø)
util 85.07% <ø> (ø)
vm 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FrederikBolding
Copy link
Contributor Author

Hmm, looks like the exports field in package.json is not supported by karma 🤔

@acolytec3
Copy link
Contributor

I think I've resolved the karma import issue. Will approve if CI passes

@FrederikBolding
Copy link
Contributor Author

There could be an argument that this should be solved in the SSZ package itself. Since other tools may struggle with the exports configuration too.

holgerd77
holgerd77 approved these changes Apr 8, 2023
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, cool 🙂, will approve and merge!

@holgerd77 holgerd77 merged commit e8cf85b into ethereumjs:master Apr 8, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Apr 8, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 EthereumJS Contributor:

GitPOAP: 2023 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@holgerd77
Copy link
Member

There could be an argument that this should be solved in the SSZ package itself. Since other tools may struggle with the exports configuration too.

If you solve this in the SSZ package let us know, then we likely also want to do another update on this. We have releases planned for roughly in 10 days or so, if this will happen it would be great if we could already take the updated version in.

@legobeat legobeat mentioned this pull request Apr 10, 2023
Closed
@wemeetagain wemeetagain mentioned this pull request Apr 10, 2023
Closed
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Apr 21, 2023
@legobeat
deps: @ethereumjs/util@8.0.0->8.0.3
0a8ffff 
8.0.4 introduces WASM-dependent ssz.
Once a version of @ethereumjs/util has been released which does not
transitively depend on WASM-dependent as-sha256, this can be lifted.

Context: ethereumjs/ethereumjs-monorepo#2622
legobeat added a commit to legobeat/eth-sig-util that referenced this pull request Apr 21, 2023
@legobeat
deps: @ethereumjs/util@8.0.0->8.0.3
bcfca18 
8.0.4 introduces WASM-dependent ssz.
Once a version of @ethereumjs/util has been released which does not
transitively depend on WASM-dependent as-sha256, this can be lifted.

Context: ethereumjs/ethereumjs-monorepo#2622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: util PR state: needs review type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrederikBolding @acolytec3 @holgerd77