Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and replace some EF bootnodes #2576

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

skylenet
Copy link
Contributor

@skylenet skylenet commented Mar 9, 2023

@holgerd77
Copy link
Member

@skylenet thanks a lot, will review soon! 🙏 🙂

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #2576 (131da11) into master (ecb62e5) will increase coverage by 0.20%.
The diff coverage is n/a.

❗ Current head 131da11 differs from pull request most recent head 6b6e108. Consider uploading reports for the commit 6b6e108 to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.13% <ø> (-0.29%) ⬇️
blockchain 90.40% <ø> (ø)
client 87.68% <ø> (+0.72%) ⬆️
common 95.82% <ø> (+0.08%) ⬆️
devp2p 91.70% <ø> (ø)
ethash ∅ <ø> (∅)
evm 79.31% <ø> (-0.09%) ⬇️
rlp ∅ <ø> (?)
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 94.16% <ø> (-0.17%) ⬇️
util 84.50% <ø> (ø)
vm 83.87% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 force-pushed the skylenet/remove-ef-bootnodes branch from 131da11 to 6b6e108 Compare March 28, 2023 07:40
@holgerd77
Copy link
Member

Rebased this via UI.

@skylenet sorry sorry sorry, this totally got forgotten. 😬 Will merge soon.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 8910fe2 into ethereumjs:master Mar 28, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Mar 28, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 EthereumJS Contributor:

GitPOAP: 2023 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants