Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: Arbitrum One support #2426

Merged
merged 2 commits into from
Nov 18, 2022
Merged

common: Arbitrum One support #2426

merged 2 commits into from
Nov 18, 2022

Conversation

Cussone
Copy link
Contributor

@Cussone Cussone commented Nov 16, 2022

Adding support for Arbitrum One layer 2 network

@Cussone Cussone mentioned this pull request Nov 16, 2022
Closed
@Cussone Cussone changed the title Common/arbitrum one support common: Arbitrum One support Nov 16, 2022
@holgerd77 holgerd77 force-pushed the common/arbitrum-one-support branch from 4fc8ab4 to ae6d09f Compare November 18, 2022 16:54
@codecov
Copy link

codecov bot commented Nov 18, 2022 •
edited
Loading

Codecov Report

Merging #2426 (ae6d09f) into master (a00251d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 89.51% <ø> (ø)
blockchain 90.03% <ø> (ø)
client 87.47% <ø> (ø)
common 98.16% <100.00%> (+0.02%) ⬆️
devp2p 91.44% <ø> (-0.44%) ⬇️
ethash ∅ <ø> (∅)
evm 79.72% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.46% <ø> (ø)
trie 90.36% <ø> (ø)
tx 97.80% <ø> (ø)
util 84.59% <ø> (ø)
vm 85.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool, thanks for submitting! 👍

Will merge (release roughly in 1-3 weeks together with other libraries).

@holgerd77 holgerd77 merged commit 161a402 into ethereumjs:master Nov 18, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Nov 18, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 EthereumJS Contributor:

GitPOAP: 2022 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: common PR state: needs review type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cussone @holgerd77