Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Releases (EVM/VM Event Emitter Fix) #2377

Merged
merged 4 commits into from
Oct 21, 2022
Merged

New Releases (EVM/VM Event Emitter Fix) #2377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe28b77
Added CHANGELOG entry, bumped version number, updated ustream depende…
holgerd77 Oct 21, 2022
385712c
Added CHANGELOG entry, bumped version number, updated ustream depende…
holgerd77 Oct 21, 2022
f09a494
Added CHANGELOG entry, bumped version number, updated ustream depende…
holgerd77 Oct 21, 2022
f478c57
Updated package-lock.json
holgerd77 Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
334 changes: 155 additions & 179 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/block/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/trie": "^5.0.1",
"@ethereumjs/tx": "^4.0.1",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"ethereum-cryptography": "^1.1.2",
"ethers": "^5.7.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/blockchain/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"@ethereumjs/ethash": "^2.0.1",
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/trie": "^5.0.1",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"abstract-level": "^1.0.3",
"debug": "^4.3.3",
"ethereum-cryptography": "^1.1.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,13 @@
"@ethereumjs/common": "3.0.1",
"@ethereumjs/devp2p": "5.0.1",
"@ethereumjs/ethash": "2.0.1",
"@ethereumjs/evm": "1.1.0",
"@ethereumjs/evm": "1.2.0",
"@ethereumjs/rlp": "4.0.0",
"@ethereumjs/statemanager": "1.0.1",
"@ethereumjs/trie": "5.0.1",
"@ethereumjs/tx": "4.0.1",
"@ethereumjs/util": "8.0.1",
"@ethereumjs/vm": "6.1.0",
"@ethereumjs/util": "8.0.2",
"@ethereumjs/vm": "6.2.0",
"abstract-level": "^1.0.3",
"body-parser": "^1.19.2",
"chalk": "^4.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"tsc": "../../config/cli/ts-compile.sh"
},
"dependencies": {
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"crc-32": "^1.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/devp2p/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"dependencies": {
"@ethereumjs/common": "^3.0.1",
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"@scure/base": "1.1.1",
"@types/bl": "^2.1.0",
"@types/k-bucket": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/ethash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"dependencies": {
"@ethereumjs/block": "^4.0.1",
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"abstract-level": "^1.0.3",
"bigint-crypto-utils": "^3.0.23",
"ethereum-cryptography": "^1.1.2"
Expand Down
8 changes: 8 additions & 0 deletions packages/evm/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
(modification: no type change headlines) and this project adheres to
[Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 1.2.0 - 2022-10-21

This release replaces the `v1.1.0` release from a couple of days ago which now becomes deprecated. The async event emitter library switch from the `async-eventemitter` package to the `eventemitter2` package turned out to be breaking along parts of the functionality.

This release therefore switches back to a modernized version of the `async-eventemitter` package - now also solving previous import problems - which has been internalized and integrated into the `@ethereumjs/util` package, see PR [#2376](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2376).

## 1.1.0 - 2022-10-18

[ DEPRECATED ]: Async event emitter library switch turned out to be breaking. If you have got problems, please update to v1.2.0 or above.

### Support for Geth genesis.json Genesis Format

For lots of custom chains (for e.g. devnets and testnets), you might come across a [Geth genesis.json config](https://geth.ethereum.org/docs/interface/private-network) which has both config specification for the chain as well as the genesis state specification.
Expand Down
4 changes: 2 additions & 2 deletions packages/evm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ethereumjs/evm",
"version": "1.1.0",
"version": "1.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I just noticed this but any reason we're using minor version updates for evm and point releases for the other packages?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I already used a minor for the first release due to the significance of the event emitter update, for the VM as well, so to indicate that this would be a release with substantial changes (which was obviously still not enough 😋).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. Lets merge it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

One note: for npm packages, package version numbers don't communicate significance (except version 1.0.0) or provide any indication of how substantial the changes are. They indicate if the release contains fixes/refactors (0.0.x), new features (0.x.0), or breaking changes (x.0.0). Of course, if ethereumjs isn't adhering to Semver this isn't true, but we've been operating under the impression that it does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, yeah, Andrew did a really great job here! 🙂 👍

I've just published all the versions, hope everything works now, otherwise let us know (respectively: some general feedback would likely be good in this case).

Yes, I know that (semver). We DO adhere to Semver. For the bugfix vs minor versions I perceive these lines as a bit blurry and not as important as for minor vs breaking. Feature additions are often so insignifcant for the user - if a new function is mainly for internal usage e.g., or if their is a slight API parameter change or so. If one would always call this out a minor version, one would very quickly land at v6.45. 😋

So I switched a bit (more) to a distinction to "what feels right to me" in these cases and I reserve minor versions more for the a bit more substantal feature additions.

Richard (from Ethers) is doing the opposite and is putting everything in bugfix releases. 😆

"description": "JavaScript Ethereum Virtual Machine (EVM) implementation",
"keywords": [
"ethereum",
Expand Down Expand Up @@ -47,7 +47,7 @@
},
"dependencies": {
"@ethereumjs/common": "^3.0.1",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"@ethersproject/providers": "^5.7.1",
"debug": "^4.3.3",
"ethereum-cryptography": "^1.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/statemanager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"devDependencies": {
"@ethereumjs/block": "^4.0.1",
"@ethereumjs/trie": "^5.0.1",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"@types/node": "^16.11.7",
"@types/tape": "^4.13.2",
"debug": "^4.3.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/trie/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
},
"dependencies": {
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"@types/readable-stream": "^2.3.13",
"ethereum-cryptography": "^1.1.2",
"readable-stream": "^3.6.0"
Expand Down
2 changes: 1 addition & 1 deletion packages/tx/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"dependencies": {
"@ethereumjs/common": "^3.0.1",
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"ethereum-cryptography": "^1.1.2",
"ethers": "^5.7.1"
},
Expand Down
4 changes: 4 additions & 0 deletions packages/util/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
(modification: no type change headlines) and this project adheres to
[Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 8.0.2 - 2022-10-21

- Added internalized and reexported modernized version of the [async-eventemitter](https://www.google.com/search?client=firefox-b-d&q=async-eventemitter+github) library, PR [#2376](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2376)

## 8.0.1 - 2022-10-19

- Added new `Lock` functionality, PR [#2308](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2308)
Expand Down
2 changes: 1 addition & 1 deletion packages/util/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ethereumjs/util",
"version": "8.0.1",
"version": "8.0.2",
"description": "A collection of utility functions for Ethereum",
"keywords": [
"ethereum",
Expand Down
8 changes: 8 additions & 0 deletions packages/vm/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
(modification: no type change headlines) and this project adheres to
[Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 6.2.0 - 2022-10-21

This release replaces the `v6.1.0` release from a couple of days ago which now becomes deprecated. The async event emitter library switch from the `async-eventemitter` package to the `eventemitter2` package turned out to be breaking along parts of the functionality.

This release therefore switches back to a modernized version of the `async-eventemitter` package - now also solving previous import problems - which has been internalized and integrated into the `@ethereumjs/util` package, see PR [#2376](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2376).

## 6.1.0 - 2022-10-18

[ DEPRECATED ]: Async event emitter library switch turned out to be breaking. If you have got problems, please update to v6.2.0 or above.

### Support for Geth genesis.json Genesis Format

For lots of custom chains (for e.g. devnets and testnets), you might come across a [Geth genesis.json config](https://geth.ethereum.org/docs/interface/private-network) which has both config specification for the chain as well as the genesis state specification.
Expand Down
6 changes: 3 additions & 3 deletions packages/vm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ethereumjs/vm",
"version": "6.1.0",
"version": "6.2.0",
"description": "An Ethereum VM implementation",
"keywords": [
"ethereum",
Expand Down Expand Up @@ -59,12 +59,12 @@
"@ethereumjs/block": "^4.0.1",
"@ethereumjs/blockchain": "^6.0.1",
"@ethereumjs/common": "^3.0.1",
"@ethereumjs/evm": "^1.1.0",
"@ethereumjs/evm": "^1.2.0",
"@ethereumjs/rlp": "^4.0.0",
"@ethereumjs/statemanager": "^1.0.1",
"@ethereumjs/trie": "^5.0.1",
"@ethereumjs/tx": "^4.0.1",
"@ethereumjs/util": "^8.0.1",
"@ethereumjs/util": "^8.0.2",
"debug": "^4.3.3",
"ethereum-cryptography": "^1.1.2",
"mcl-wasm": "^0.7.1",
Expand Down