common: use a default chain name in fromGethGenesis if no chain name specified #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Should we make the chain |
|
hmm, can pass |
acolytec3
reviewed
Sep 28, 2022
packages/common/src/common.ts
Outdated
| @@ -157,7 +157,7 @@ export class Common extends EventEmitter { | |||
| /** | |||
| * Static method to load and set common from a geth genesis json | |||
| * @param genesisJson json of geth configuration | |||
| * @param { chain, genesisHash, hardfork } to futher configure the common instance | |||
| * @param { chain, genesisHash, hardfork } to futher configure the common instance, mandatory option: `chain` representing custom chain name` | |||
There was a problem hiding this comment.
This comment is no longer relevant.
g11tech
changed the title
g11tech
changed the title
ScottyPoi
pushed a commit
that referenced
this pull request
Sep 29, 2022
…specified (#2319) * common: make chain name mandatory in fromGethGenesis * improve comment * change startegy to just pass name custom * undo comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like files might not have name property in them and hence would cause common constructor to error when undefined chain name gets passed.
To prevent this scenario
chainrepresenting custom chain name is now mandatory field