Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethash: remove isTruthy and isFalsy #2253

Merged
merged 3 commits into from
Aug 30, 2022
Merged

ethash: remove isTruthy and isFalsy #2253

merged 3 commits into from
Aug 30, 2022

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Aug 30, 2022 •
edited
Loading

Extracts ethash from #2233

@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited
Loading

Codecov Report

Merging #2253 (fb6c54b) into master (742514a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 92.77% <ø> (ø)
blockchain 88.47% <ø> (ø)
client 87.05% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.25% <ø> (ø)
ethash ∅ <ø> (∅)
evm 79.11% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 88.16% <ø> (ø)
trie 89.43% <ø> (ø)
tx 97.98% <ø> (ø)
util 92.33% <ø> (ø)
vm 85.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

acolytec3
acolytec3 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrocheleau gabrocheleau merged commit f441c83 into master Aug 30, 2022
@holgerd77 holgerd77 deleted the ethash/remove-isTruthy-isFalsy branch March 2, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochem-brouwer jochem-brouwer jochem-brouwer approved these changes

@acolytec3 acolytec3 acolytec3 approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

@faustbrian faustbrian Awaiting requested review from faustbrian

Assignees
No one assigned
Labels
package: ethash PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrocheleau @acolytec3 @jochem-brouwer