Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace nyc configurations with c8 configurations #2192

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 19, 2022

c8 supports reading the old nyc configurations but it makes more sense to rename them to the names that c8 itself uses.

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #2192 (669d40f) into master (f0516de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 93.07% <ø> (ø)
blockchain 88.82% <ø> (ø)
client 86.70% <ø> (ø)
common 98.09% <ø> (ø)
devp2p 92.25% <ø> (ø)
ethash ∅ <ø> (∅)
evm 79.07% <ø> (ø)
statemanager 88.71% <ø> (ø)
trie 89.26% <ø> (ø)
tx 97.98% <ø> (ø)
util 93.14% <ø> (ø)
vm 85.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faustbrian faustbrian marked this pull request as ready for review August 19, 2022 12:43
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit: might have been nice to use git mv for renaming to preserve the file history, but I guess in the cases of these super small configuration files this is not absolutely necessary.

@holgerd77 holgerd77 merged commit e16b893 into master Aug 19, 2022
@holgerd77 holgerd77 deleted the drop-nyc-remainder branch August 19, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants