-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: set the default hard fork to merge #2087
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks good! However some merged-related tests are now failing in
Didn't check in detail but perhaps all that's required is to manually provide a pre-merge HF for those test cases |
thanks @acolytec3 for fixes, got distracted after pushing initial PR 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏼
Nice, cool, didn't assume this to be so narrowly scoped respectively going through with so few changes. 😀 🤩 Seems Emmett already did a lot of base work here with adding the explicit HF (Common) instantiations in the round before upgrading to London. Great! |
set the default hard fork to merge
Closes #2015