Ensure EVM runs when nonce is zero

[jochem-brouwer]

This PR is based on an old version of master. In here I address the nonce bug in #2009.

I think that pre-EVM calls the state should be exactly as it is pre-EVM. Since we have introduced this "nonce - 1" logic at some point this should be removed (and I think this might be easy). This first version does the depth check and removes the 'nonce - 1' if the depth is zero.

I tried removing it by also moving the "increment nonce" logic in interpreter.ts the same way how I moved it now in runTx, but this has a failing chainstart test RecursiveCreateContractsCreate4Contracts_d0g0v0_Frontier which I should look into.

[codecov]

Codecov Report

Merging #2054 (8be5b40) into master (2dd63b9) will decrease coverage by 0.04%.
The diff coverage is 70.00%.

Flag	Coverage Δ
block	84.01% <ø> (ø)
blockchain	80.10% <ø> (ø)
client	78.37% <ø> (ø)
common	94.90% <ø> (ø)
devp2p	82.73% <ø> (ø)
ethash	90.81% <ø> (ø)
evm	40.89% <100.00%> (-0.08%)	⬇️
statemanager	84.55% <ø> (ø)
trie	80.84% <ø> (-0.49%)	⬇️
tx	92.18% <ø> (ø)
util	87.22% <ø> (ø)
vm	78.51% <50.00%> (-0.15%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[jochem-brouwer]

Ah right, we cannot update interpreter.ts to update the nonce before runCall. The reason is: if the current account A which executes a CREATE then creates an account B which recursively calls back into account A, which then does another CREATE, will then not have the "new nonce" and thus will try to create a new account at B, while it should create an account at another address C.

If you recursively call back into the CREATE-ing account, then the nonce never updates, so it always tries to CREATE at the same address.

[acolytec3]

@jochem-brouwer I reverted the changes I made around setting the default caller and fixed the 2 broken evm tests based on it producing the correct address/code so should be good to go unless you have more changes to make.

[acolytec3]

Not sure if there is more work to be done but this looks good to me!

[jochem-brouwer]

Thanks!