-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devp2p/client: upgrade to eth/66 #1331
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to successfully run peer-communication.ts
so that looks good. As far as syncing the chain, here are my observations:
- mainnet, ropsten, and goerli all start syncing just fine
- rinkeby doesn't seem to find any suitable peers so not sure if the bootnodes there just haven't adopted
eth/66
or not - kovan won't start syncing though that doesn't appear to be an issue related to this PR as it throws the same error when trying to sync from the
master
branch
log error if no headers are returned Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Ironically, it looks like my suggested change is causing the CI to fail though I can say with confidence that this is not always falsy. Is this a case of
|
Cool! 🎉 |
This PR upgrades
devp2p
andclient
to communicateeth/66
since geth plans to deprecateeth/65
after london is activated on mainnet.I updated devp2p's
peer-communication.ts
which was working for me (would appreciate someone else to run it to verify everything looks good), along with client's full sync withnpm run client:start
.devp2p
has no breaking changes as the payload logic is handled in theclient
, but theclient
will no longer support versions prior toeth/66
since structural changes needed to be made to support the encoding and decoding of messages to handle the newreqId
field.