Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baseFeePerGas to block header from rpc + fix readme typo #1330

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Add baseFeePerGas to block header from rpc + fix readme typo #1330

merged 4 commits into from
Jul 8, 2021

Conversation

mfornet
Copy link
Contributor

@mfornet mfornet commented Jul 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #1330 (0960478) into master (ba6de67) will increase coverage by 1.21%.
The diff coverage is 0.00%.

Impacted file tree graph

Flag Coverage Δ
block 85.43% <0.00%> (-0.14%) ⬇️
blockchain 83.46% <ø> (ø)
client 83.57% <ø> (-0.56%) ⬇️
common 93.75% <ø> (ø)
devp2p 83.90% <ø> (+0.14%) ⬆️
ethash 82.83% <ø> (ø)
tx 88.36% <ø> (ø)
vm 82.64% <ø> (+3.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

mfornet added a commit to Near-One/rainbow-bridge that referenced this pull request Jul 1, 2021
@mfornet
Use patched version from ethereumjs block
d220e26 
while ethereumjs/ethereumjs-monorepo#1330 is
    merged
@mfornet mfornet mentioned this pull request Jul 1, 2021
Closed
@mfornet mfornet requested a review from holgerd77 July 1, 2021 17:12
@ryanio ryanio changed the title Fix blockHeaderFromRpc after EIP-1559 + Typo Add baseFeePerGas to block header from rpc + readme typo Jul 8, 2021
ryanio
ryanio approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanio ryanio changed the title Add baseFeePerGas to block header from rpc + readme typo Add baseFeePerGas to block header from rpc + fix readme typo Jul 8, 2021
@ryanio ryanio merged commit 9037a94 into ethereumjs:master Jul 8, 2021
@ryanio ryanio mentioned this pull request Jul 8, 2021
Merged
holgerd77 added a commit that referenced this pull request Jul 8, 2021
@holgerd77
block -> release: added note on #1330 (baseFeePerGas in blockHeaderFr…
89da310 
…omRpc()) to CHANGELOG
holgerd77 added a commit that referenced this pull request Jul 8, 2021
@holgerd77
block -> release: added note on #1330 (baseFeePerGas in blockHeaderFr…
c70ee9c 
…omRpc()) to CHANGELOG
holgerd77 added a commit that referenced this pull request Jul 8, 2021
@holgerd77
block -> release: added note on #1330 (baseFeePerGas in blockHeaderFr…
2759b0f 
…omRpc()) to CHANGELOG
@holgerd77 holgerd77 mentioned this pull request Jul 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 left review comments

@ryanio ryanio ryanio approved these changes

Assignees
No one assigned
Labels
package: block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfornet @ryanio @holgerd77