-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util, devp2p: add dist.browser to package.json #1184
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks, this is fitting well since I was planning to do a devp2p
release during the week (unless anyone has any objections). 😄
"node": ">=8.0.0" | ||
}, | ||
"files": [ | ||
"dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional to exclude bin
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that folder is not needed anymore since it now only contains the typescript source file. the actual built file we are interested in (that the package.json
key for bin: ethereumjs
points to) is now at dist/bin/cli.js
This PR:
dist.browser
topackage.json
forutil
anddevp2p
types
key topackage.json
fordevp2p