Clique small fixes / follow-up work #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
…` as number of blocks, not number of array entries * don't reset votes on epoch blocks to keep in case of reorgs, but only count in `cliqueUpdateVotes()` if blockNumber >= last epoch block
* in trimming signer votes, keep votes until `lastEpochBlockNumber - CLIQUE_SIGNER_HISTORY_BLOCK_LIMIT` (as a safe number for potential recounts on reorgs)
…er.validateCliqueDifficulty()`
ryanio
force-pushed
the
clique-small-fixes
branch
from
67fe4af to
9db72c2
Compare
|
Can this PR get an update? Is this generally ready for review? |
|
@holgerd77 yes now ready for review, thanks! |
holgerd77
approved these changes
Feb 5, 2021
| // If cliqueSigner is provided, seal block with provided privateKey. | ||
| if (options.cliqueSigner) { | ||
| this.extraData = this.cliqueSealBlock(options.cliqueSigner) | ||
| } |
There was a problem hiding this comment.
Nice, also like that the private key is not residing in the library, was a bit worried that we introduce some new potential security risks here.
| const signerFound = signerList.find((signer) => { | ||
| return signer.toBuffer().equals(signerAddress) | ||
| return signer.equals(signerAddress) |
There was a problem hiding this comment.
Ah, yes, that's really a much nicer API! 😄
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some further work from review in #1032:
cliqueSigner?: BufferCLIQUE_SIGNER_HISTORY_BLOCK_LIMITas number of blocks, not number of last statescliqueUpdateVotes()by checking if the vote's blockNumber >= last epoch block.blockchain.cliqueActiveSigners()inBlockHeader.validateCliqueDifficulty()to not add to block's minimum blockchain interface (discussion)Address.equals(address)checks with ethereumjs-util v7.0.8