Devp2p: fix a peer data processing bug #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
…e loop on retrieval of malformed data
holgerd77
force-pushed
the
fix-devp2p-data-processing-bug
branch
from
9183abd to
c379f14
Compare
cgewecke
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical devp2p bug where peer data processing stays in an endless while loop on retrieval of malformed data, code change should be relatively self-explanatory, so if an error is thrown "early enough" before the data is consumed the loop will be executed ever and ever again (while the peer is disconnected anyhow).
Stumbled upon this in the client where the following error has been hammered out in an endless fashion on some malformed peer data:
ERROR [01-19|18:55:59] AssertionError [ERR_ASSERTION]: should have valid tag: c9994806780c34bf140355955ad1d2f5aeb38a61cea495379a435931d8bf7e6e / 176a38c21a95454505a8d05627c9975ce84673da8903b33fe48b80b082595cc0 at new AssertionError (internal/assert/assertion_error.js:447:11) at Object.assertEq (/ethereumjs-vm/packages/devp2p/dist/util.js:73:15) at ECIES._decryptMessage (/EthereumJS/ethereumjs-vm/packages/devp2p/dist/rlpx/ecies.js:126:16) at ECIES.parseAuthPlain (/EthereumJS/ethereumjs-vm/packages/devp2p/dist/rlpx/ecies.js:197:32) at ECIES.parseAuthEIP8 (/EthereumJS/ethereumjs-vm/packages/devp2p/dist/rlpx/ecies.js:236:14) at Peer._handleAuth (/EthereumJS/ethereumjs-vm/packages/devp2p/dist/rlpx/peer.js:238:32) at Peer._onSocketData (/EthereumJS/ethereumjs-vm/packages/devp2p/dist/rlpx/peer.js:443:30) at Socket.emit (events.js:314:20) at addChunk (_stream_readable.js:297:12) at readableAddChunk (_stream_readable.js:272:9)I think I already had this in other occasions before as well.
This might also solve some client "hanging" situations - so this behavior might have also been occurred together with the error not propagated through as an output for the client log, so the situation just looked as if the client just hangs. That's just an assumption though, we'll eventually see.