Add package level lint:fix back (#3799)

* bring back package specific tsconfig.lint

* Revert "make eslint happy"

This reverts commit 3f3ef49.

* Bring back lint:fix

* Add parser options

* more devp2p specific stuff

* Bring back lint script because why not

* lint

config/eslint.cjs

@@ -108,7 +108,6 @@ module.exports = {
     'no-dupe-class-members': 'off',
     'no-extra-semi': 'off',
     'no-redeclare': 'off',
-    'no-undef': 'off',
     'no-unused-vars': 'off',
     'no-var': 'error',
     'object-shorthand': 'error',
@@ -130,11 +129,10 @@ module.exports = {
         'implicit-dependencies/no-implicit': 'off',
         'import/no-extraneous-dependencies': 'off',
         'no-console': 'off',
-        '@typescript-eslint/no-floating-promises': 'warn',
       },
     },
     {
-      files: ['**/examples/**/*', '**/benchmarks/*.ts', ],
+      files: ['**/examples/**/*.ts', '**/benchmarks/*.ts', ],
       rules: {
         'implicit-dependencies/no-implicit': 'off',
         'import/no-extraneous-dependencies': 'off',
@@ -150,6 +148,16 @@ module.exports = {
         'no-restricted-syntax': 'off',
       },
     },
+    {
+      files: ['packages/devp2p/**'],
+      rules: {
+        '@typescript-eslint/no-floating-promises': 'off',
+        'no-redeclare': 'off',
+        'no-undef': 'off', // temporary until fixed: 'NodeJS' is not defined
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
     {
       files: ['packages/wallet/**'],
       rules: {

packages/block/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/block/package.json

@@ -31,6 +31,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- block",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=../../config/vitest.config.browser.mts",

packages/block/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/blockchain/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/blockchain/package.json

@@ -31,6 +31,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- blockchain",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=./vitest.config.browser.mts",

packages/blockchain/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/client/.eslintignore

@@ -0,0 +1,2 @@
+devnets/**/*.ts
+archive/**/*.ts

packages/client/.eslintrc.cjs

@@ -0,0 +1,14 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['bin/**.ts', 'test/sim/**.ts', 'examples/**/*.ts'],
+      rules: {
+        'no-console': 'off',
+      },
+    },
+  ],
+}

packages/client/package.json

@@ -34,6 +34,8 @@
     "coverage": "npx vitest --coverage --coverage.include=src --coverage.reporter=lcov run test/* -c=./vitest.config.unit.ts",
     "docs:build": "typedoc --options typedoc.cjs --tsconfig tsconfig.prod.cjs.json",
     "examples": "tsx ../../scripts/examples-runner.ts -- client",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "preinstall": "npm run binWorkaround",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:unit && npm run test:integration",

packages/client/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/common/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/common/package.json

@@ -44,6 +44,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- common",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=../../config/vitest.config.browser.mts",

packages/common/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/devp2p/.eslintrc.cjs

@@ -0,0 +1,20 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  rules: {
+    '@typescript-eslint/no-floating-promises': 'off',
+    'no-redeclare': 'off',
+    'no-undef': 'off', // temporary until fixed: 'NodeJS' is not defined
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/devp2p/package.json

@@ -47,6 +47,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- devp2p",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "vitest run",
     "test:node": "npm run test",

packages/devp2p/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/ethash/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/ethash/package.json

@@ -31,6 +31,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- ethash",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npx vitest run",
     "tsc": "../../config/cli/ts-compile.sh"

packages/evm/.eslintrc.cjs

@@ -0,0 +1,20 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  rules: {
+    '@typescript-eslint/no-use-before-define': 'off',
+    'no-invalid-this': 'off',
+    'no-restricted-syntax': 'off',
+  },
+  overrides: [
+    {
+      files: ['test/util.ts', 'test/tester/**/*.ts', 'examples/**/*.ts'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/evm/package.json

@@ -34,6 +34,8 @@
     "examples": "tsx ../../scripts/examples-runner.ts -- evm",
     "examples:build": "npx embedme README.md",
     "formatTest": "node ./scripts/formatTest",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "profiling": "0x ./benchmarks/run.js profiling",
     "test": "npm run test:node && npm run test:browser",

packages/evm/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/genesis/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/genesis/package.json

@@ -43,6 +43,8 @@
     "examples": "tsx ../../scripts/examples-runner.ts -- genesis",
     "examples:build": "npx embedme README.md",
     "docs:build": "typedoc --options typedoc.cjs",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node",
     "test:browser": "npx vitest run --config=../../config/vitest.config.browser.mts",

packages/genesis/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/mpt/.eslintrc.cjs

@@ -0,0 +1,14 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['benchmarks/*.ts', 'examples/**/*'],
+      rules: {
+        'no-console': 'off',
+      },
+    },
+  ],
+}

packages/mpt/package.json

@@ -33,6 +33,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- mpt",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "profiling": "tsc --target ES5 benchmarks/random.ts && 0x benchmarks/random.js",
     "test": "npm run test:node && npm run test:browser",

packages/mpt/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/rlp/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  rules: {
+    '@typescript-eslint/no-use-before-define': 'off',
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/rlp/package.json

@@ -43,6 +43,8 @@
     "coverage": "npx vitest --coverage --coverage.include=src run",
     "examples": "tsx ../../scripts/examples-runner.ts -- rlp",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=./vitest.config.browser.mts",

packages/rlp/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/statemanager/.eslintrc.cjs

@@ -0,0 +1,20 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  rules: {
+    '@typescript-eslint/no-use-before-define': 'off',
+    'no-invalid-this': 'off',
+    'no-restricted-syntax': 'off',
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/statemanager/package.json

@@ -32,6 +32,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- statemanager",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh && npm run test:node",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=./vitest.config.browser.mts",

packages/statemanager/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}

packages/tx/.eslintrc.cjs

@@ -0,0 +1,15 @@
+module.exports = {
+  extends: '../../config/eslint.cjs',
+  parserOptions: {
+    project: ['./tsconfig.lint.json'],
+  },
+  overrides: [
+    {
+      files: ['examples/**/*'],
+      rules: {
+        'no-console': 'off',
+        '@typescript-eslint/no-unused-vars': 'off',
+      },
+    },
+  ],
+}

packages/tx/package.json

@@ -38,6 +38,8 @@
     "docs:build": "typedoc --options typedoc.cjs",
     "examples": "tsx ../../scripts/examples-runner.ts -- tx",
     "examples:build": "npx embedme README.md",
+    "lint": "eslint --config .eslintrc.cjs . --ext .js,.ts",
+    "lint:fix": "eslint --fix --config .eslintrc.cjs . --ext .js,.ts",
     "prepublishOnly": "../../config/cli/prepublish.sh",
     "test": "npm run test:node && npm run test:browser",
     "test:browser": "npx vitest run --config=./vitest.config.browser.mts",

packages/tx/tsconfig.lint.json

@@ -0,0 +1,3 @@
+{
+  "extends": "../../config/tsconfig.lint.json"
+}