tx: ensure eip3860 txs can have more than max_initcode_size data if t…

…o field is non-empty (#2575)

packages/tx/src/eip1559Transaction.ts

@@ -192,7 +192,8 @@ export class FeeMarketEIP1559Transaction extends BaseTransaction<FeeMarketEIP155
     this._validateYParity()
     this._validateHighS()
 
-    if (this.common.isActivatedEIP(3860)) {
+    const createContract = txData.to === undefined || txData.to === null
+    if (createContract && this.common.isActivatedEIP(3860)) {
       checkMaxInitCodeSize(this.common, this.data.length)
     }
 

packages/tx/src/eip2930Transaction.ts

@@ -169,7 +169,8 @@ export class AccessListEIP2930Transaction extends BaseTransaction<AccessListEIP2
     this._validateYParity()
     this._validateHighS()
 
-    if (this.common.isActivatedEIP(3860)) {
+    const createContract = txData.to === undefined || txData.to === null
+    if (createContract && this.common.isActivatedEIP(3860)) {
       checkMaxInitCodeSize(this.common, this.data.length)
     }
     const freeze = opts?.freeze ?? true

packages/tx/src/eip4844Transaction.ts

@@ -143,7 +143,8 @@ export class BlobEIP4844Transaction extends BaseTransaction<BlobEIP4844Transacti
     this._validateYParity()
     this._validateHighS()
 
-    if (this.common.isActivatedEIP(3860)) {
+    const createContract = txData.to === undefined || txData.to === null
+    if (createContract && this.common.isActivatedEIP(3860)) {
       checkMaxInitCodeSize(this.common, this.data.length)
     }
 

packages/tx/src/legacyTransaction.ts

@@ -134,7 +134,8 @@ export class Transaction extends BaseTransaction<Transaction> {
       }
     }
 
-    if (this.common.isActivatedEIP(3860)) {
+    const createContract = txData.to === undefined || txData.to === null
+    if (createContract && this.common.isActivatedEIP(3860)) {
       checkMaxInitCodeSize(this.common, this.data.length)
     }
 

packages/tx/test/eip3860.spec.ts

@@ -0,0 +1,69 @@
+import { Chain, Common, Hardfork } from '@ethereumjs/common'
+import { Address } from '@ethereumjs/util'
+import * as tape from 'tape'
+
+import { TransactionFactory } from '../src'
+
+const common = new Common({
+  chain: Chain.Mainnet,
+  hardfork: Hardfork.Merge,
+  eips: [3860, 4844, 4895],
+})
+
+const maxInitCodeSize = common.param('vm', 'maxInitCodeSize')
+const txTypes = [0, 1, 2, 5]
+const addressZero = Address.zero()
+
+tape('[EIP3860 tests]', function (t) {
+  t.test('Should instantiate create txs with MAX_INITCODE_SIZE', (st) => {
+    const data = Buffer.alloc(Number(maxInitCodeSize))
+    for (const txType of txTypes) {
+      try {
+        TransactionFactory.fromTxData({ data, type: txType }, { common })
+        st.ok('Instantiated create tx with MAX_INITCODE_SIZE data')
+      } catch (e) {
+        st.fail('Did not instantiate create tx with MAX_INITCODE_SIZE')
+      }
+    }
+    st.end()
+  })
+
+  t.test('Should instantiate txs with MAX_INITCODE_SIZE data', (st) => {
+    const data = Buffer.alloc(Number(maxInitCodeSize))
+    for (const txType of txTypes) {
+      try {
+        TransactionFactory.fromTxData({ data, type: txType, to: addressZero }, { common })
+        st.ok('Instantiated tx with MAX_INITCODE_SIZE')
+      } catch (e) {
+        st.fail('Did not instantiated tx with MAX_INITCODE_SIZE')
+      }
+    }
+    st.end()
+  })
+
+  t.test('Should not instantiate create txs with MAX_INITCODE_SIZE+1 data', (st) => {
+    const data = Buffer.alloc(Number(maxInitCodeSize) + 1)
+    for (const txType of txTypes) {
+      try {
+        TransactionFactory.fromTxData({ data, type: txType }, { common })
+        st.fail('Instantiated create tx with MAX_INITCODE_SIZE+1')
+      } catch (e) {
+        st.ok('Did not instantiate create tx with MAX_INITCODE_SIZE+1')
+      }
+    }
+    st.end()
+  })
+
+  t.test('Should instantiate txs with MAX_INITCODE_SIZE+1 data', (st) => {
+    const data = Buffer.alloc(Number(maxInitCodeSize) + 1)
+    for (const txType of txTypes) {
+      try {
+        TransactionFactory.fromTxData({ data, type: txType, to: addressZero }, { common })
+        st.ok('Instantiated tx with MAX_INITCODE_SIZE+1')
+      } catch (e) {
+        st.fail('Did not instantiate tx with MAX_INITCODE_SIZE+1')
+      }
+    }
+    st.end()
+  })
+})