This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
k-bucket Update to v5.0.0 / esModuleInterop issue on client integration Fix #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, one nit comment |
jochem-brouwer
previously approved these changes
Sep 25, 2020
This was referenced Sep 25, 2020
|
Wonder if this already fixed a super-significant bug along the way, I am seeing numbers of peers on the client run I've actually never seen before? 🤔
The change in |
…rop type export issue
holgerd77
force-pushed
the
fix-typescript-type-exports
branch
from
6b41348 to
6861315
Compare
|
@jochem-brouwer thanks for the quick look, have updated! |
|
Or eventually it's also the |
|
I actually do recall seeing that amount of peers before @holgerd77, but that might be because I bootstrapped it to my own node? It could indeed be this Thanks for the type update. Will approve. |
jochem-brouwer
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87 and continues #79