This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'devp2p:util' logger was always a bit of an alien with no semantics, being used for logging output from the generic
assertEq
function. This lead to the case that a) errors are not associated to a corresponding logger and therefore are more difficult to track and b) not logged at all when not using 'devp2p:*' but a selected logger like 'devp2p:rlpx'.This PR fixes this and removes the 'devp2p:util' logger. A logger ('debug') is instead passed to the 'assertEq' method from the respective modules and the error gets logged in a context-aware manner.
Example: